lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [PATCH] Gaurantee spinlocks implicit barrier for !PREEMPT_COUNT
    Hi Vineet,

    Our stress testing campaign has just successfully completed on this
    patch. It seems to solve several issues we have seen in unpatched
    versions, amongst others the original timer issue, a crash in hrtimer
    rb-tree manipulation etc.

    Greetings,
    Christian

    On Wed, Apr 03, 2013 at 07:41:22PM +0530, Vineet Gupta wrote:
    > spinlocks built in a !PREEMPT_COUNT config don't have the compiler
    > barrier provided by preempt_* routines. This can break lot of code which
    > relies on barrier semantics.
    >
    > This manifested as random crashes in timer code when stress testing
    > ARC Linux (3.9-rc3): !SMP && !PREEMPT_COUNT
    >
    > [...]
    >
    > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
    > Reported-by: Christian Ruppert <christian.ruppert@abilis.com>
    Tested-by: Christian Ruppert <christian.ruppert@abilis.com>
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Christian Ruppert <christian.ruppert@abilis.com>
    > Cc: Pierrick Hascoet <pierrick.hascoet@abilis.com>
    > Cc: Robert Love <rml@tech9.net>
    > Cc: kpreempt-tech@lists.sourceforge.net
    > Cc: Frederic Weisbecker <fweisbec@gmail.com>
    > Cc: Steven Rostedt <srostedt@redhat.com>
    > Cc: Peter Zijlstra <peterz@infradead.org>
    > Cc: Ingo Molnar <mingo@kernel.org>
    > Cc: linux-kernel@vger.kernel.org
    > [...]
    --
    Christian Ruppert , <christian.ruppert@abilis.com>
    /|
    Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pré-Fleuri
    _// | bilis Systems CH-1228 Plan-les-Ouates
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-04-04 18:01    [W:3.134 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site