lkml.org 
[lkml]   [2013]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set
On 04/30, Oleg Nesterov wrote:
>
> On 04/29, Colin Cross wrote:
> >
> > @@ -46,10 +46,10 @@ static int try_to_freeze_tasks(bool user_only)
> > todo = 0;
> > read_lock(&tasklist_lock);
> > do_each_thread(g, p) {
> > - if (p == current || !freeze_task(p))
> > + if (p == current || freezer_should_skip(p))
> > continue;
> >
> > - if (!freezer_should_skip(p))
> > + if (freeze_task(p))
> > todo++;
>
> What if we race with freezer_count() ?
>
> try_to_freeze_tasks() can wrongly succeed leaving the running task
> unfrozen, no?

Ah, no, sorry for noise.

Oleg.



\
 
 \ /
  Last update: 2013-04-30 19:21    [W:0.090 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site