lkml.org 
[lkml]   [2013]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec
On 04/30/2013 04:09 PM, Fabio Baltieri wrote:
> Move ab8500 clock control definitions to the ab8500 codec driver,
> leaving only card specific setting in mop500_ab8500_ctrls.
>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
> ---
> sound/soc/codecs/ab8500-codec.c | 10 ++++++++++
> sound/soc/ux500/mop500_ab8500.c | 10 ----------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
> index a153b16..925e625 100644
> --- a/sound/soc/codecs/ab8500-codec.c
> +++ b/sound/soc/codecs/ab8500-codec.c
> @@ -1615,6 +1615,16 @@ static SOC_ENUM_SINGLE_EXT_DECL(soc_enum_sidstate, enum_sid_state);
> static SOC_ENUM_SINGLE_EXT_DECL(soc_enum_ancstate, enum_anc_state);
>
> static struct snd_kcontrol_new ab8500_ctrls[] = {
> + /* Digital interface - Clocks */
> + SOC_SINGLE("Digital Interface Master Generator Switch",
> + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN,
> + 1, 0),
> + SOC_SINGLE("Digital Interface 0 Bit-clock Switch",
> + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0,
> + 1, 0),
> + SOC_SINGLE("Digital Interface 1 Bit-clock Switch",
> + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1,
> + 1, 0),

I think this patch as it is is fine. But those three controls looks like
they should be converted to DAPM widgets.

- Lars


\
 
 \ /
  Last update: 2013-04-30 17:01    [W:2.654 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site