Messages in this thread Patch in this message | | | Date | Tue, 30 Apr 2013 07:28:17 -0600 | From | Jonathan Corbet <> | Subject | Re: dummy irq trace 'Flags mismatch' |
| |
On Tue, 30 Apr 2013 06:59:22 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
> Or have it depend on CONFIG_EXPERT would probably make most sense ... ?
We could also just have it tell you when you screwed up? Something like the following (compile tested only)?
jon --- dummy-irq: require the user to specify an IRQ number
Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c index 7014167..c37eeed 100644 --- a/drivers/misc/dummy-irq.c +++ b/drivers/misc/dummy-irq.c @@ -19,7 +19,7 @@ #include <linux/irq.h> #include <linux/interrupt.h> -static int irq; +static int irq = -1; static irqreturn_t dummy_interrupt(int irq, void *dev_id) { @@ -36,6 +36,10 @@ static irqreturn_t dummy_interrupt(int irq, void *dev_id) static int __init dummy_irq_init(void) { + if (irq < 0) { + printk(KERN_ERR "dummy-irq: no IRQ given. Use irq=N\n"); + return -EIO; + } if (request_irq(irq, &dummy_interrupt, IRQF_SHARED, "dummy_irq", &irq)) { printk(KERN_ERR "dummy-irq: cannot register IRQ %d\n", irq); return -EIO;
| |