lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: avoid using uninitialized value in from queue_var_store
On Wed, Apr 03 2013, Arnd Bergmann wrote:
> As found by gcc-4.8, the QUEUE_SYSFS_BIT_FNS macro creates functions
> that use a value generated by queue_var_store independent of whether
> that value was set or not.
>
> block/blk-sysfs.c: In function 'queue_store_nonrot':
> block/blk-sysfs.c:244:385: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Unlike most other such warnings, this one is not a false positive,
> writing any non-number string into the sysfs files indeed has
> an undefined result, rather than returning an error.

Huh indeed, thanks Arnd. Queued up.

--
Jens Axboe



\
 
 \ /
  Last update: 2013-04-03 22:41    [W:0.020 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site