lkml.org 
[lkml]   [2013]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 08/30] bonding: IFF_BONDING is not stripped on enslave failure
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: "nikolay@redhat.com" <nikolay@redhat.com>

    [ Upstream commit b6a5a7b9a528a8b4c8bec940b607c5dd9102b8cc ]

    While enslaving a new device and after IFF_BONDING flag is set, in case
    of failure it is not stripped from the device's priv_flags while
    cleaning up, which could lead to other problems.
    Cleaning at err_close because the flag is set after dev_open().

    v2: no change

    Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/bonding/bond_main.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -1949,6 +1949,7 @@ err_detach:
    write_unlock_bh(&bond->lock);

    err_close:
    + slave_dev->priv_flags &= ~IFF_BONDING;
    dev_close(slave_dev);

    err_unset_master:



    \
     
     \ /
      Last update: 2013-04-29 21:21    [W:4.441 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site