Messages in this thread | | | Date | Fri, 26 Apr 2013 10:14:26 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] dmaengine: use phys_addr_t for slave configuration |
| |
On Fri, 26 Apr 2013, Linus Walleij wrote:
> The documentation already says these are physical addresses, and > we have concluded that any translation into the DMA address space > needs to reside in the dmaengine driver, so change the type of > the passed arguments. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Vinod Koul <vinod.koul@intel.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > include/linux/dmaengine.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 91ac8da..681df5f9 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -361,8 +361,8 @@ enum dma_slave_buswidth { > */ > struct dma_slave_config { > enum dma_transfer_direction direction; > - dma_addr_t src_addr; > - dma_addr_t dst_addr; > + phys_addr_t src_addr; > + phys_addr_t dst_addr; > enum dma_slave_buswidth src_addr_width; > enum dma_slave_buswidth dst_addr_width; > u32 src_maxburst;
Makes a lot more sense.
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |