lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.
On Thu, Apr 25, 2013 at 09:34:37AM +0200, Ingo Molnar wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Thu, 25 Apr 2013 08:57:04 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> >
> > > > PF_THREAD_BOUND was removed/replaced in linux-next's a9ab775bc
> > > > ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE")
> > >
> > > I don't see PF_THREAD_BOUND being removed by commit a9ab775bc. Did you
> > > mean some other commit?
> >
> > commit 14a40ffccd6163bbcd1d6f32b28a88ffe6149fc6
> > Author: Tejun Heo <tj@kernel.org>
> > Date: Tue Mar 19 13:45:20 2013 -0700
> >
> > sched: replace PF_THREAD_BOUND with PF_NO_SETAFFINITY
>
> I don't think much action is needed: whenever someone integrates the
> workqueue tree with these reboot changes, or the workqueue changes hit
> upstream, a s/PF_THREAD_BOUND/PF_NO_SETAFFINITY should do the trick,
> right?
>
> Btw., if that's true then the workqueue tree should probably grow this
> helper:
>
> #define PF_THREAD_BOUND PF_NO_SETAFFINITY

Andrew, how about I add:
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -155,6 +155,9 @@ static int __init reboot_setup(char *str)
}
__setup("reboot=", reboot_setup);

+#ifndef PF_THREAD_BOUND
+#define PF_THREAD_BOUND PF_NO_SETAFFINITY
+#endif

static void migrate_to_reboot_cpu(void)
{
to this patch and then add another patch to the series to remove those.
That will make the stable pull more clear and accomplish the same final
outcome.

Thanks,
Robin


\
 
 \ /
  Last update: 2013-04-25 18:01    [W:0.040 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site