Messages in this thread | | | Date | Thu, 25 Apr 2013 07:44:17 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] random: Account for entropy loss due to overwrites |
| |
On 04/25/2013 07:38 AM, Linus Torvalds wrote: > This doesn't work AT ALL. You even hint at the reason why in your message. > > On Tue, Apr 23, 2013 at 9:26 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> >> As such, this conservatism seems more than justified. Note, however, >> that attempting to add one bit of entropy will never succeed; nor will >> two bits unless the pool is completely empty. These roundoff >> artifacts could be improved by using fixed-point arithmetic and adding >> some number of fractional entropy bits. > > Take a look at "add_interrupt_randomness()". Hmm.. >
<facepalm>
Right. Before July of last year add_interrupt_randomness() called add_timer_randomness() which credits up to 11 bits, but not anymore.
-ESTALEBRAIN.
OK, so we need to track fractional bits.
-hpa
| |