lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/9] crypto: ux500/hash - Set DMA configuration though dma_slave_config()
From
Pls include Magnus.p.persson@stericsson.com on all these crypto/hash
postings.

On Thu, Apr 18, 2013 at 12:26 PM, Lee Jones <lee.jones@linaro.org> wrote:

> The DMA controller currently takes configuration information from
> information passed though dma_channel_request(), but it shouldn't.
> Using the API, the DMA channel should only be configured during
> a dma_slave_config() call.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Andreas Westin <andreas.westin@stericsson.com>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

(...)
> #define HASH_BLOCK_SIZE 64
> +#define HASH_DMA_FIFO 4

This is an address so write 0x0004 here please. Some hex notation atleast.

> /**
> * struct hash_device_data - structure for a hash device.
> - * @base: Pointer to the hardware base address.
> + * @base: Pointer to virtual base address of the hash device.
> + * @phybase: Pointer to physical memory location of the hash device.
> * @list_node: For inclusion in klist.
> * @dev: Pointer to the device dev structure.
> * @ctx_lock: Spinlock for current_ctx.
> @@ -361,6 +363,7 @@ struct hash_req_ctx {
> */
> struct hash_device_data {
> struct hash_register __iomem *base;
> + phys_addr_t phybase;

What you pass to the config function is a dma_addr_t actually.

This is the same thing on the platform, but generally:

phys_addr_t = in the address space as the memory controller sees it.
dma_addr_t = in the address space as the DMA controller sees it.

Often the same. Not always. So use dma_addr_t.

Apart from this a real nice patch!

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-04-25 14:01    [W:0.176 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site