lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 2/2] ARM: Enable selection of SMP operations at boot time
On Thu, 25 Apr 2013, Will Deacon wrote:
> On Wed, Apr 24, 2013 at 07:40:19PM +0100, Stefano Stabellini wrote:
> > From: Jon Medhurst <tixy@linaro.org>
> >
> > Add a new 'smp_init' hook to machine_desc so platforms can specify a
> > function to be used to setup smp ops instead of having a statically
> > defined value. The hook must return true when smp_ops are initialized.
> > If false the static mdesc->smp_ops will be used by default.
> >
> > Signed-off-by: Jon Medhurst <tixy@linaro.org>
> > Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > ---
> > arch/arm/include/asm/mach/arch.h | 4 ++++
> > arch/arm/kernel/setup.c | 10 ++++++----
> > 2 files changed, 10 insertions(+), 4 deletions(-)
>
> [...]
>
> > if (is_smp()) {
> > - if (psci_smp_available())
> > - smp_set_ops(&psci_smp_ops);
> > - else if (mdesc->smp)
> > - smp_set_ops(mdesc->smp);
> > + if (!mdesc->smp_init || !mdesc->smp_init()) {
>
> Minor nit, but this feels backwards to me. We usually return 0 on success,
> yet we're saying here that if mdesc->smp_init() returns 0, then we go and
> override the smp ops.

I am OK with changing the interface to return an int instead of a bool,
but given that Nicolas is the main user of smp_init at the moment, I'll
wait for his opinion.


\
 
 \ /
  Last update: 2013-04-25 13:21    [W:0.107 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site