lkml.org 
[lkml]   [2013]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: Convert logging messages
On Tue, 23 April 2013 10:59:54 -0700, Joe Perches wrote:
> On Mon, 2013-04-22 at 10:31 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> > > On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > > > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > > > > }
> > > > > list_add(&dev->list, &blkmtd_device_list);
> > > > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > > > > - dev->mtd.name + strlen("block2mtd: "),
> > > > > - dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > > > > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n",
> > > > > + dev->mtd.index,
> > > > > + dev->mtd.name + strlen("block2mtd: "),
> > > > > + dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > > >
> > > > I personally dislike the indent-to-braces style because it causes
> > > > unnecessary churn in patches like this.
> > >
> > > It comes from an automated emacs conversion.
> >
> > Then please teach your emacs to be a better tool.
>
> Because you personally dislike something isn't
> enough of a reason for me to change my tools nor
> enough of a reason for me to add a special
> exception to my tools for your preferences.

In that case: NAK.

Because you personally dislike something isn't
enough of a reason for me to take your patch nor
enough of a reason for me to add a special
exception to my standards for your preferences.

Cuts both way, it seems.

Jörn

--
"Translations are and will always be problematic. They inflict violence
upon two languages." (translation from German)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-04-23 20:41    [W:0.089 / U:3.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site