lkml.org 
[lkml]   [2013]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 2/3] power: power_supply: Add core support for supplied_from
On 04/01/2013 03:45 PM, Rhyland Klein wrote:
> This patch adds support for supplies to register a list of char *'s
> which represent the list of supplies which supply them. This is the
> opposite as the supplied_to list.

This patch resolves the concerns I had before, so,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

> diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c

> +static bool __power_supply_is_supplied_by(struct power_supply *supplier,
> + struct power_supply *supply)
> +{
> + int i;
> +
> + if (!supply->supplied_from && !supplier->supplied_to)
> + return false;

Nit: that somewhat duplicates the if below, so perhaps could just be
removed?

> + /* Support both supplied_to and supplied_from modes */
> + if (supply->supplied_from) {
> + if (!supplier->name)
> + return false;

Likewise, I'm still not convinced these !name tests should be required.

However, there's no harm here I think, so it's fine.


\
 
 \ /
  Last update: 2013-04-03 00:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog