Messages in this thread | | | Date | Tue, 2 Apr 2013 17:10:12 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 4/5 v11] iommu/fsl: Add additional iommu attributes required by the PAMU driver. |
| |
On Fri, Mar 29, 2013 at 01:24:01AM +0530, Varun Sethi wrote: > +/* cache stash targets */ > +enum stash_target { > + IOMMU_ATTR_CACHE_L1 = 1, > + IOMMU_ATTR_CACHE_L2, > + IOMMU_ATTR_CACHE_L3, > +}; > + > +/* This attribute corresponds to IOMMUs capable of generating > + * a stash transaction. A stash transaction is typically a > + * hardware initiated prefetch of data from memory to cache. > + * This attribute allows configuring stashig specific parameters > + * in the IOMMU hardware. > + */ > + > +struct iommu_stash_attribute { > + u32 cpu; /* cpu number */ > + u32 cache; /* cache to stash to: L1,L2,L3 */ > +}; > +
I would prefer these PAMU specific enum and struct to be in a pamu-specific iommu-header.
Joerg
| |