| Date | Thu, 18 Apr 2013 11:45:23 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking |
| |
On Thu, Apr 18, 2013 at 11:11:57AM +0100, Lee Jones wrote: > +void d40_log_gim_unmask(u32 *src_cfg, u32 *dst_cfg) { > + > + *src_cfg |= 1 << D40_SREG_CFG_LOG_GIM_POS; > + *dst_cfg |= 1 << D40_SREG_CFG_LOG_GIM_POS;
So, in patch 3, you started using the BIT() macro. But here it's fine not to because... ?
Use one notation or the other, don't mix them together.
|