lkml.org 
[lkml]   [2013]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args()
    Date


    > -----Original Message-----
    > From: Timur Tabi [mailto:timur@tabi.org]
    > Sent: 2013年4月17日 11:31
    > To: Tang Yuantian-B29983
    > Cc: Grant Likely; devicetree-discuss; linuxppc-dev@lists.ozlabs.org; lkml;
    > Rob Herring
    > Subject: Re: [PATCH v2] of/base: release the node correctly in
    > of_parse_phandle_with_args()
    >
    > Tang Yuantian-B29983 wrote:
    > >> >On Tue, Apr 9, 2013 at 10:36 PM,<Yuantian.Tang@freescale.com> wrote:
    > >>> > >
    > >>> > >+ /* Found it! return success */
    > >> >
    > >> >I'm pretty sure this comment is in the wrong place.
    >
    > > It is not perfect, but acceptable.
    >
    > Like I said, I'm pretty sure it's in the wrong place.
    >

    It was placed on ELSE statement originally, I moved it to IF statement.
    Why is it so wrong?

    Thanks,
    Yuantian
    \
     
     \ /
      Last update: 2013-04-17 07:21    [W:3.885 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site