Messages in this thread | | | From | Tang Yuantian-B29983 <> | Subject | RE: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args() | Date | Wed, 17 Apr 2013 04:49:20 +0000 |
| |
> -----Original Message----- > From: Timur Tabi [mailto:timur@tabi.org] > Sent: 2013年4月17日 11:31 > To: Tang Yuantian-B29983 > Cc: Grant Likely; devicetree-discuss; linuxppc-dev@lists.ozlabs.org; lkml; > Rob Herring > Subject: Re: [PATCH v2] of/base: release the node correctly in > of_parse_phandle_with_args() > > Tang Yuantian-B29983 wrote: > >> >On Tue, Apr 9, 2013 at 10:36 PM,<Yuantian.Tang@freescale.com> wrote: > >>> > > > >>> > >+ /* Found it! return success */ > >> > > >> >I'm pretty sure this comment is in the wrong place. > > > It is not perfect, but acceptable. > > Like I said, I'm pretty sure it's in the wrong place. >
It was placed on ELSE statement originally, I moved it to IF statement. Why is it so wrong?
Thanks, Yuantian
| |