lkml.org 
[lkml]   [2013]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/6] Chainsaw efivars.c
Date
From: Matt Fleming <matt.fleming@intel.com>

drivers/firmware/efivars.c has grown pretty large and is ~2K lines.

Inside efivars.c there's currently,

o code for handling EFI variables at the firmware-level
o sysfs code for exposing EFI variables
o a new EFI variable filesystem
o a persistent storage backend

all intertwined and smushed together. This situation is only going to get worse
as new EFI support is added.

We need an interface that hides the EFI variable operations in use so code
isn't tempted to access them directly, e.g. efivarfs currently uses '__efivars'
which means it doesn't work for CONFIG_GOOGLE_SMI as that uses different
variable ops. With this interface in place, we can start moving independent
code out into separate files, allowing users to only turn on the functionality
that they want.

This patch series introduces the new efivar_entry API, and splits out the major
parts of efivars.c into new files. In particular, having the efivarfs code
under fs/ allows building an efivarfs.ko module, which means mount(8) can
automatically load it.

The remaining EFI code is repositioned under drivers/firmware/efi/.

The series is also available on the 'chainsaw' branch at,

git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/linux.git

Changes in v2:

- Add Reviewed-by/Acked-by tags from Mike
- Allow both EFI variable ops to be built as requested by Mike (PATCH 2)
- Fix deadlock and remove unnecessary logic changes in the pstore patch
reported by Seiji (PATCH 3)

Matt Fleming (5):
efi: move utf16 string functions to efi.h
efivars: Keep a private global pointer to efivars
efivars: efivar_entry API
efivars: Move pstore code into the new EFI directory
efivarfs: Move to fs/efivarfs

Tom Gundersen (1):
efi: split efisubsystem from efivars

MAINTAINERS | 13 +-
drivers/firmware/Kconfig | 36 +-
drivers/firmware/Makefile | 2 +-
drivers/firmware/efi/Kconfig | 39 +
drivers/firmware/efi/Makefile | 6 +
drivers/firmware/efi/efi-pstore.c | 244 +++++
drivers/firmware/efi/efi.c | 134 +++
drivers/firmware/efi/efivars.c | 615 +++++++++++
drivers/firmware/efi/vars.c | 1046 ++++++++++++++++++
drivers/firmware/efivars.c | 2171 -------------------------------------
drivers/firmware/google/gsmi.c | 30 +-
fs/Kconfig | 1 +
fs/Makefile | 1 +
fs/efivarfs/Kconfig | 12 +
fs/efivarfs/Makefile | 7 +
fs/efivarfs/file.c | 111 ++
fs/efivarfs/inode.c | 173 +++
fs/efivarfs/internal.h | 22 +
fs/efivarfs/super.c | 266 +++++
include/linux/efi.h | 133 ++-
20 files changed, 2828 insertions(+), 2234 deletions(-)
create mode 100644 drivers/firmware/efi/Kconfig
create mode 100644 drivers/firmware/efi/Makefile
create mode 100644 drivers/firmware/efi/efi-pstore.c
create mode 100644 drivers/firmware/efi/efi.c
create mode 100644 drivers/firmware/efi/efivars.c
create mode 100644 drivers/firmware/efi/vars.c
delete mode 100644 drivers/firmware/efivars.c
create mode 100644 fs/efivarfs/Kconfig
create mode 100644 fs/efivarfs/Makefile
create mode 100644 fs/efivarfs/file.c
create mode 100644 fs/efivarfs/inode.c
create mode 100644 fs/efivarfs/internal.h
create mode 100644 fs/efivarfs/super.c

--
1.7.10.4



\
 
 \ /
  Last update: 2013-04-17 00:21    [W:0.060 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site