lkml.org 
[lkml]   [2013]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: reiserfs: Use kstrdup function
On Fri 12-04-13 04:20:18, Alexandru Gheorghiu wrote:
> Use kstrdup function instead of kmalloc and strcpy.
> Patch found using coccinelle.
Thanks for the patch but I already have a similar patch in my tree.

Honza
>
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
> ---
> fs/reiserfs/super.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 194113b..f8a23c3 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -1147,8 +1147,7 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
> "on filesystem root.");
> return 0;
> }
> - qf_names[qtype] =
> - kmalloc(strlen(arg) + 1, GFP_KERNEL);
> + qf_names[qtype] = kstrdup(arg, GFP_KERNEL);
> if (!qf_names[qtype]) {
> reiserfs_warning(s, "reiserfs-2502",
> "not enough memory "
> @@ -1156,7 +1155,6 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
> "quotafile name.");
> return 0;
> }
> - strcpy(qf_names[qtype], arg);
> if (qtype == USRQUOTA)
> *mount_options |= 1 << REISERFS_USRQUOTA;
> else
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2013-04-16 19:21    [W:0.037 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site