Messages in this thread | | | Date | Tue, 16 Apr 2013 09:19:07 +0800 | From | Chen Gang <> | Subject | Re: [PATCH v3] kernel: kallsyms: memory override issue, need check destination buffer length |
| |
On 2013年04月15日 13:48, Rusty Russell wrote: > Chen Gang <gang.chen@asianux.com> writes: > >> > We don't export any symbols > 128 characters, but if we did then >> > kallsyms_expand_symbol() would overflow the buffer handed to it. >> > So we need check destination buffer length when copying. >> > >> > the related test: >> > if we define an EXPORT function which name more than 128. >> > will panic when call kallsyms_lookup_name by init_kprobes on booting. >> > after check the length (provide this patch), it is ok. >> > >> > Implementaion: >> > add additional destination buffer length parameter (maxlen) >> > if uncompressed string is too long (>= maxlen), it will be truncated. >> > not check the parameters whether valid, since it is a static function. > Thanks, applied. > > I've put this in my modules-next branch. >
thank you very much to spend time resources for it.
and next, I should be careful to send patch. so do not wast other members' time resources for my careless mistakes.
the details are: a. if modify code, need always compile again, at least. b. reduce reply times, so can reduce some of my waste information.
I will let additional machine (a PC) for test and compile instead of my current work machine, so when I have to do another things (normally, it is), the individual machine can continue compiling or testing.
thanks again.
:-)
> Cheers, > Rusty. > >
-- Chen Gang
Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |