Messages in this thread Patch in this message | | | From | Jonas Gorski <> | Subject | [PATCH] checkpatch: whitelist SUPPORTED_*/ADVERTISED_* defines from ethtool.h | Date | Sat, 13 Apr 2013 16:10:57 +0200 |
| |
Don't complain about camelcase when using SUPPORTED_*/ADVERTISED_* defines, they are part of the user api so can't be (easily) fixed.
Removes false positives in e.g. ethernet drivers like:
WARNING: Avoid CamelCase: <SUPPORTED_Autoneg> + SUPPORTED_Autoneg |
Signed-off-by: Jonas Gorski <jogo@openwrt.org> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b28cc38..349559a4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2931,6 +2931,7 @@ sub process { if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /^(?:SUPPORTED|ADVERTISED)_\w*/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE", -- 1.7.10.4
| |