Messages in this thread | | | Date | Sat, 13 Apr 2013 20:22:59 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/1] uprobes/perf: Avoid perf_trace_buf_prepare/submit if ->perf_events is empty |
| |
On 04/13, Oleg Nesterov wrote: > > On 04/12, Steven Rostedt wrote: > > > > Can you make the necessary changes elsewhere? I talked with Frederic on > > IRC and he's a bit busy with other work. But he did say he would review > > changes that you make. > > Sure, will be happy to do.
Everything looks trivial except DECLARE_EVENT_CLASS()->perf_trace_*() which should also check __task != NULL.
In fact this _looks_ simple too, we could move TP_perf_assign() logic into TP_ARGS(), but probably this is too ugly. I'll try think more.
Oleg.
| |