lkml.org 
[lkml]   [2013]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]
On 2013-04-11 20:05, Greg Kroah-Hartman wrote:
> On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote:
>> Ian Abbott <abbotti@mev.co.uk> wrote:
>>
>>>> Don't use create_proc_read_entry() as that is deprecated, but rather use
>>>> proc_create_data() and seq_file instead.
>>>
>>> It seems to work okay and is simpler than I thought it would be! You changed
>>> the mode of the file to 0644 for some reason though. Please change it back to
>>> 0444 or S_IFREG | S_IRUGO. Thanks.
>>
>> Ah... cut'n'paste error. Sorry about that.
>
> I can fix that up by hand when I apply it, no worries.

You may need to sync with linux-next first, particularly commit
e784788ddb7000dbea8bd2986a3f83c4d77f96ff by Al Viro "get rid of a bunch
of open-coded create_proc_read_entry()".

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


\
 
 \ /
  Last update: 2013-04-12 13:41    [W:0.070 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site