lkml.org 
[lkml]   [2013]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] posix-timers: Correctly get dying task time sample in posix_cpu_timer_schedule()
On Mon, Apr 01, 2013 at 08:07:59AM +0800, Chen Gang wrote:
> On 2013年03月30日 21:15, Frederic Weisbecker wrote:
> > In order to arm the next timer to schedule, we take a sample of the
> > current process or thread cputime.
> >
> > If the task is dying though, we don't arm anything but we
> > cache the remaining timer expiration delta for further reads.
> >
> > Something similar is performed in posix_cpu_timer_get() but
> > here we forget to take the process wide cputime sample
> > before caching it.
> >
> > As a result we are storing random stack content, leading
> > every further reads of that timer to return junk values.
> >
> > Fix this by taking the appropriate sample in the case of
> > process wide timers.
> >
> > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > Reported-by: Chen Gang <gang.chen@asianux.com>
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Stanislaw Gruszka <sgruszka@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Chen Gang <gang.chen@asianux.com>
> > ---
>
> thank you for mark me as reported by, although I reported too late
> (Andrew Morton is the first reporter).

Bug reporters simply deserve to be credited, no sorting is required ;)

>
> next, I should continue to try to find another issues about kernel.

I encourage you to do so :)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-04-11 18:21    [W:0.076 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site