Messages in this thread Patch in this message | | | Date | Wed, 10 Apr 2013 13:26:05 -0400 (EDT) | From | Eric Paris <> | Subject | Re: [PATCH -next] audit: remove duplicated include from audit.c |
| |
net/netlink.h includes linux/netlink.h but linux/netlink.h does not include net/netlink.h
since the audit code uses the nlmsg_* functions provided in net/netlink.h it seems we need this include.
since the audit code uses netlink_unicast provided in linux/netlink.h it seems we need that include.
I don't see duplication even if by chance one of them would have included the other...
----- Original Message ----- > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Remove duplicated include. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > kernel/audit.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 488f85f..9377913 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -58,7 +58,6 @@ > #ifdef CONFIG_SECURITY > #include <linux/security.h> > #endif > -#include <net/netlink.h> > #include <linux/freezer.h> > #include <linux/tty.h> > #include <linux/pid_namespace.h> > >
| |