Messages in this thread | | | From | hayeswang <> | Subject | RE: [PATCH net-next 2/7] r8169: Update PHY settings of RTL8111G | Date | Tue, 2 Apr 2013 10:19:17 +0800 |
| |
Francois Romieu [mailto:romieu@fr.zoreil.com] > Sent: Tuesday, April 02, 2013 6:21 AM > To: Hayeswang > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 2/7] r8169: Update PHY settings > of RTL8111G > > Hayes Wang <hayeswang@realtek.com> : > > - Replace the current settings with rtl_writephy and rtl_readphy. > > For the hardware, the settings are same with previous ones. This > > make the setting method like the previous chips. > > - Add new PHY settings. > > Would you mind spliting it in two ?
OK.
[...] > > - if (r8168_phy_ocp_read(tp, 0xa466) & 0x0100) > > - rtl_w1w0_phy_ocp(tp, 0xc41a, 0x0002, 0x0000); > > - else > > - rtl_w1w0_phy_ocp(tp, 0xbcc4, 0x0000, 0x0002); > ^^^^^^ > This one was not right, was it ?
No, it was not right. It seems a mistake for copying and pasting.
| |