Messages in this thread | | | Date | Fri, 8 Mar 2013 08:29:34 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator |
| |
On Thu, Mar 07, 2013 at 01:16:08PM -0800, Andrew Chew wrote: > The backlight enable regulator is specified in the device tree node for > backlight. > > Signed-off-by: Andrew Chew <achew@nvidia.com>
This looks good in general. I'd like to see Alex' comment addressed and perhaps the commit message shouldn't be device tree specific, since the same can be done with legacy board setup code. It would be nice if it'd mention something about why the regulator is added.
Thierry [unhandled content-type:application/pgp-signature] | |