lkml.org 
[lkml]   [2013]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] epoll: trim epitem by one cache line on x86_64
On Thu, 7 Mar 2013 10:32:40 +0000 Eric Wong <normalperson@yhbt.net> wrote:

> Andrew Morton <akpm@linux-foundation.org> wrote:
> > It's going to be hard to maintain this - someone will change something
> > sometime and break it. I suppose we could add a runtime check if we
> > cared enough. Adding a big fat comment to struct epitem might help.
>
> Thanks for looking at this patch. I'll send a patch with a comment
> about keeping epitem size in check. Also, would adding (with comments):
>
> BUILD_BUG_ON(sizeof(struct epitem) > 128);
>
> ...be too heavy-handed? I used that in my testing. I'll check for:
> sizeof(void *) <= 8 too; in case 128-bit machines appear...

I guess such a check might avoid accidents in the future. If it
becomes a problem, we can always delete it.



\
 
 \ /
  Last update: 2013-03-09 01:41    [W:0.044 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site