lkml.org 
[lkml]   [2013]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: holtek: Holtek devices depends on USB_HID
On 03/08/13 13:00, Jiri Kosina wrote:
> On Fri, 8 Mar 2013, Randy Dunlap wrote:
>
>>> In the HID drivers tranport cleanup series, I removed the dependency
>>> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
>>> extensively on usb calls.
>>>
>>> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
>>>
>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>>
>> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
>
> Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH,
> hence that shouldn't be a problem.

You are correct. I was testing 3.9-rc1 + mmotm, where the latter contains
some incorrect HID patches (from linux-next).

Thanks.

> There used to be a problem in linux-next, but that should be fixed by
> 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have
> pushed out yesterday.
>


--
~Randy


\
 
 \ /
  Last update: 2013-03-08 22:42    [W:0.043 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site