lkml.org 
[lkml]   [2013]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
    On 03/08/13 12:08, Tony Lindgren wrote:
    > * Stephen Boyd <sboyd@codeaurora.org> [130308 11:54]:
    >> On 03/08/13 11:48, Tony Lindgren wrote:
    >>> * Stephen Boyd <sboyd@codeaurora.org> [130308 10:21]:
    >>>> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
    >>>> index 081de6f..4ea3e9d 100644
    >>>> --- a/arch/arm/kernel/smp_twd.c
    >>>> +++ b/arch/arm/kernel/smp_twd.c
    >>>> @@ -227,7 +227,7 @@ static void __cpuinit twd_calibrate_rate(void)
    >>>>
    >>>> static irqreturn_t twd_handler(int irq, void *dev_id)
    >>>> {
    >>>> - struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
    >>>> + struct clock_event_device *evt = dev_id;
    >>>>
    >>>> if (twd_timer_ack()) {
    >>>> evt->event_handler(evt);
    >>>>
    >>> Yup thanks that fixes it, both fixes are needed. So for this patch + the
    >>> two fixes please feel free to add:
    >>>
    >>> Acked-by: Tony Lindgren <tony@atomide.com>
    >> Great. Thanks for testing.
    > Hmm noticed one more thing: vexpress no longer boots in qemu for
    > me after applying this. Sorry did not get any debug_ll output, but
    > maybe you can take a look at it. I tested with omap2plus_defconfig +
    > linaro-qemu:
    >
    > $ qemu-system-arm -machine vexpress-a9 -m 1024 -curses -net nic -net \
    > user -serial stdio -append console=ttyAMA0,115200n8 rw \
    > root=/dev/mmcblk0p2 rootwait physmap.enabled=0 -kernel zImage \
    > -initrd initrd.img -sd rootfs.img
    >
    >

    I wonder if you're hitting something similar to this issue on versatile
    boards [1]. Can you try that patch? Otherwise I will try to get qemu
    running (something I've never done, do you have instructions?).

    [1] http://article.gmane.org/gmane.linux.ports.arm.kernel/221539

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    hosted by The Linux Foundation



    \
     
     \ /
      Last update: 2013-03-08 22:02    [W:2.754 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site