Messages in this thread | | | From | <> | Date | Fri, 8 Mar 2013 14:15:35 +0100 | Subject | Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols |
| |
On 05:23 Fri 08 Mar , Masami Hiramatsu wrote: > (2013/03/07 19:44), oskar.andero@sonymobile.com wrote: > > From: Bjorn Davidsson <bjorn.davidsson@sonymobile.com> > > > > The kprobes blacklist contains x86-specific symbols. > > Looking for these in kallsyms takes unnecessary time > > during startup on non-X86 platform. > > Added #ifdef CONFIG_X86 around them. > > Right. however, it might be better break that into > common and arch-specific lists, because there may be > other arch-specific non-probe-able functions on each > architecture...
Ok. You mean adding, for instance, a kprobe_blacklist_arch[] in arch/x86 somewhere or did you have something else in mind? I guess we preferably want to get rid of the #ifdef.
> Would you know some other black points on your platform?
Not that we are aware of.
> Thank you, > > > > > Reviewed-by: Radovan Lekanovic <radovan.lekanovic@sonymobile.com> > > Signed-off-by: Björn Davidsson <bjorn.davidsson@sonymobile.com> > > Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com> > > --- > > kernel/kprobes.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > > index e35be53..8c3796f 100644 > > --- a/kernel/kprobes.c > > +++ b/kernel/kprobes.c > > @@ -95,9 +95,11 @@ static raw_spinlock_t *kretprobe_table_lock_ptr(unsigned long hash) > > */ > > static struct kprobe_blackpoint kprobe_blacklist[] = { > > {"preempt_schedule",}, > > +#ifdef CONFIG_X86 > > {"native_get_debugreg",}, > > {"irq_entries_start",}, > > {"common_interrupt",}, > > +#endif > > {"mcount",}, /* mcount can be called from everywhere */ > > {NULL} /* Terminator */ > > }; > > > > > -- > Masami HIRAMATSU > IT Management Research Dept. Linux Technology Center > Hitachi, Ltd., Yokohama Research Laboratory > E-mail: masami.hiramatsu.pt@hitachi.com > >
-Oskar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |