lkml.org 
[lkml]   [2013]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] [SCSI] bfa: Use GFP_ATOMIC under spin_lock
    This is always called with spinlocks held so it should use
    GFP_ATOMIC. The call tree is:

    -> bfad_drv_start()
    Takes spin_lock_irqsave(&bfad->bfad_lock, flags);
    -> bfa_fcs_pbc_vport_init()
    -> bfa_fcb_pbc_vport_create()

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

    diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
    index a5f7690..d144a06 100644
    --- a/drivers/scsi/bfa/bfad.c
    +++ b/drivers/scsi/bfa/bfad.c
    @@ -491,7 +491,7 @@ bfa_fcb_pbc_vport_create(struct bfad_s *bfad, struct bfi_pbc_vport_s pbc_vport)
    struct bfad_vport_s *vport;
    int rc;

    - vport = kzalloc(sizeof(struct bfad_vport_s), GFP_KERNEL);
    + vport = kzalloc(sizeof(struct bfad_vport_s), GFP_ATOMIC);
    if (!vport) {
    bfa_trc(bfad, 0);
    return;

    \
     
     \ /
      Last update: 2013-03-08 13:43    [W:3.270 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site