lkml.org 
[lkml]   [2013]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] ssbi: Fix exit mismatch in remove function
On Wed, Mar 06, 2013 at 04:29:44PM -0800, David Brown wrote:
> msm_ssbi_remove is referenced with __exit_p, but not declared with
> __exit. This causes a warning when the driver is not built as a
> module:
>
> drivers/ssbi/ssbi.c:341:23: warning: 'msm_ssbi_remove' defined but not used [-Wunused-function]
>
> Fix by adding the __exit declaration to the function.
>
> Signed-off-by: David Brown <davidb@codeaurora.org>
> ---
> drivers/ssbi/ssbi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssbi/ssbi.c b/drivers/ssbi/ssbi.c
> index 86d8416..4d503da 100644
> --- a/drivers/ssbi/ssbi.c
> +++ b/drivers/ssbi/ssbi.c
> @@ -337,7 +337,7 @@ err_get_mem_res:
> return ret;
> }
>
> -static int msm_ssbi_remove(struct platform_device *pdev)
> +static int __exit msm_ssbi_remove(struct platform_device *pdev)

No, remove the __exit_p marking instead, unless you want your kernel to
be oopsed :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-03-07 02:41    [W:0.163 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site