Messages in this thread | | | Date | Tue, 05 Mar 2013 15:33:58 -0500 (EST) | Subject | Re: WARNING at tty_buffer.c:428 process_one_work() | From | David Miller <> |
| |
From: Jiri Slaby <jslaby@suse.cz> Date: Tue, 05 Mar 2013 21:27:59 +0100
> On 03/05/2013 09:03 PM, David Miller wrote: >> From: Jiri Slaby <jslaby@suse.cz> >> Date: Tue, 05 Mar 2013 20:44:49 +0100 >> >>> Hi, I must admit I don't understand. I now checked both of them and they >>> call uart_handle_sysrq_char unconditionally, or? >> >> Nope, in the sunsab.c receive function, we used to handle the SYSRQ >> stuff before break checking when TTY is NULL, now we don't. > > But how could tty be NULL in there? subsab enables interrupts after the > TTY is open and disables before it is closed/hupped. So the tty couldn't > be NULL there, right?
TTY is NULL until bootup and SYSRQ works perfectly fine during this time when sunsab is the console, which via sunsab_console_setup() invokes sunsab_startup() which requests the IRQ.
| |