Messages in this thread Patch in this message | | | Date | Tue, 5 Mar 2013 18:47:27 +0800 | From | Greg KH <> | Subject | Re: [PATCH] staging: android: ashmem: Add support for 32bit ashmem calls in a 64bit kernel |
| |
On Tue, Mar 05, 2013 at 10:38:48AM +0000, Serban Constantinescu wrote: > On 05/03/13 10:27, Greg KH wrote: > >On Tue, Mar 05, 2013 at 10:18:27AM +0000, Serban Constantinescu wrote: > >>Android's shared memory subsystem, Ashmem, does not support calls from a > >>32bit userspace in a 64 bit kernel. This patch adds support for syscalls > >>coming from a 32bit userspace in a 64bit kernel. > >> > >>The patch has been successfully tested on ARMv8 AEM(64bit > >>platform model) and Versatile Express A9(32bit platform). > >> > >>Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com> > >>--- > >> drivers/staging/android/ashmem.c | 22 +++++++++++++++++++++- > >> drivers/staging/android/ashmem.h | 6 ++++++ > >> 2 files changed, 27 insertions(+), 1 deletion(-) > > > >Ok, what has changed from your previous version that I rejected that is > >going to actually allow this to build? > > I had to add <linux/compat.h> for a successful build on x86_64. The > attached hunk is the only change added.
Ok, please say that. I deal with over 7000 patches a year, there is no way I can remember what the difference is between this one, and the previous one I rejected. Especially as I reviewed about 30 patches inbetween the time I rejected it and you sent this update.
> >diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > >index 72064fc..e96f381 100644 > >--- a/drivers/staging/android/ashmem.c > >+++ b/drivers/staging/android/ashmem.c > >@@ -31,6 +31,7 @@ > > #include <linux/bitops.h> > > #include <linux/mutex.h> > > #include <linux/shmem_fs.h> > >+#include <linux/compat.h> > > #include "ashmem.h" > > > > #define ASHMEM_NAME_PREFIX "dev/ashmem/" > > > > > >Hint, you gotta tell me what version of the patch this is, and what > >changed, otherwise I'll just assume this is a resend of the previous > >patch and go ahead and delete it from my queue. > > Sorry - same patch as before, the one that had John and Arve's ack, > plus the above hunk.
That is not what I meant, please go read Section 2 of the Documentation/SubmittingPatches file for what I need to see here.
thanks,
greg k-h
| |