lkml.org 
[lkml]   [2013]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kexec: consolidate crash late initialization
On Wed, May 30, 2012 at 02:05:09PM +0400, Vladimir Davydov wrote:
> Use one module_init() instead of two.

I'm not sure I understand the motivation for this change.

> ---
> kernel/kexec.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4e2e472..c3341cb 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1240,7 +1240,6 @@ static int __init crash_notes_memory_init(void)
> }
> return 0;
> }
> -module_init(crash_notes_memory_init)
>
>
> /*
> @@ -1520,7 +1519,13 @@ static int __init crash_save_vmcoreinfo_init(void)
> return 0;
> }
>
> -module_init(crash_save_vmcoreinfo_init)
> +static int __init crash_init(void)
> +{
> + crash_notes_memory_init();
> + crash_save_vmcoreinfo_init();
> + return 0;
> +}
> +module_init(crash_init)
>
> /*
> * Move into place and start executing a preloaded standalone
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>


\
 
 \ /
  Last update: 2013-03-05 04:21    [W:0.051 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site