Messages in this thread | | | Date | Mon, 04 Mar 2013 07:55:27 +0000 | From | "Jan Beulich" <> | Subject | Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend. |
| |
>>> On 03.03.13 at 11:20, Paul Bolle <pebolle@tiscali.nl> wrote: > Perhaps Konrad, Jan, Or Ian can tell whether the patch still needs to go > in stable as is, because the problem it fixes is more severe than the > problem it apparently creates. Maybe a mainline fix is needed before > this can go in, or perhaps even a stable specific fix (if context > changes are to blame).
For one, a fix for the (indeed valid) compiler warning has been in Konrad's tree for several days (http://git.kernel.org/cgit/linux/kernel/git/konrad/xen.git/commit/drivers/block/xen-blkback/blkback.c?id=a72d9002f80bffd7e4c7d60e5a9caa0cddffe894).
And second, there's nothing really being fixed with the patch in question here. The title is kind of misleading, as the handle coming from the frontend is - without said patch - in the worst case being used for the very message that triggered the compiler warning. Nothing else is affected, the code just gave the impression that the handle was used.
IOW I don't see why this got proposed for stable at all.
Jan
| |