lkml.org 
[lkml]   [2013]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/4] uprobes/tracing: Kill the pointless seq_print_ip_sym() call
    seq_print_ip_sym(ip) in print_uprobe_event() is pointless,
    kallsyms_lookup(ip) can not resolve a user-space address.

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    ---
    kernel/trace/trace_uprobe.c | 8 +-------
    1 files changed, 1 insertions(+), 7 deletions(-)

    diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
    index af5b773..8e00901 100644
    --- a/kernel/trace/trace_uprobe.c
    +++ b/kernel/trace/trace_uprobe.c
    @@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e
    field = (struct uprobe_trace_entry_head *)iter->ent;
    tu = container_of(event, struct trace_uprobe, call.event);

    - if (!trace_seq_printf(s, "%s: (", tu->call.name))
    - goto partial;
    -
    - if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
    - goto partial;
    -
    - if (!trace_seq_puts(s, ")"))
    + if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip))
    goto partial;

    data = (u8 *)&field[1];
    --
    1.5.5.1


    \
     
     \ /
      Last update: 2013-03-29 19:41    [W:8.527 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site