lkml.org 
[lkml]   [2013]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused
On Fri, 29 Mar 2013, Tony Prisk wrote:

> On 29/03/13 10:16, Arnd Bergmann wrote:
> > On Thursday 28 March 2013, Arnd Bergmann wrote:
> >> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
> >> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
> >> inside of an #ifdef to work around an unused function warning.
> > Hi Greg,
> >
> > Apparently the warning is now also in 3.8.5, so you might want to backport
> > this fix as well after you send it upstream.
> >
> > Arnd
> Grr, my bad - I originally wrote the patch with the forward decl
> #ifdef'd as well, but Alan pointed out that it didn't need to be. I
> thought I recompiled it after the change, but obviously not.

It's my fault too. I didn't realize the compiler would issue a warning
about a static declaration with no definition.

Alan Stern



\
 
 \ /
  Last update: 2013-03-29 15:41    [W:0.042 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site