Messages in this thread | | | Date | Thu, 28 Mar 2013 21:14:14 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH -mm -next] ipc,sem: untangle RCU locking with find_alloc_undo |
| |
On 03/28/2013 09:00 PM, Michel Lespinasse wrote: > On Thu, Mar 28, 2013 at 8:32 AM, Rik van Riel <riel@surriel.com> wrote: >> The ipc semaphore code has a nasty RCU locking tangle, with both >> find_alloc_undo and semtimedop taking the rcu_read_lock(). The >> code can be cleaned up somewhat by only taking the rcu_read_lock >> once. >> >> The only caller of find_alloc_undo is in semtimedop. >> >> This should solve the trinity issue reported by Sasha Levin. >> >> Reported-by: Sasha Levin <sasha.levin@oracle.com> >> Signed-off-by: Rik van Riel <riel@redhat.com> > > Looks good^Wbetter. I have nothing specific to say other than I've > been staring at it for 10 minutes :) > > Reviewed-by: Michel Lespinasse <walken@google.com>
And the warnings are gone:
Tested-by: Sasha Levin <sasha.levin@oracle.com>
Thanks, Sasha
| |