Messages in this thread | | | Date | Thu, 28 Mar 2013 18:00:52 -0700 | Subject | Re: [PATCH -mm -next] ipc,sem: untangle RCU locking with find_alloc_undo | From | Michel Lespinasse <> |
| |
On Thu, Mar 28, 2013 at 8:32 AM, Rik van Riel <riel@surriel.com> wrote: > The ipc semaphore code has a nasty RCU locking tangle, with both > find_alloc_undo and semtimedop taking the rcu_read_lock(). The > code can be cleaned up somewhat by only taking the rcu_read_lock > once. > > The only caller of find_alloc_undo is in semtimedop. > > This should solve the trinity issue reported by Sasha Levin. > > Reported-by: Sasha Levin <sasha.levin@oracle.com> > Signed-off-by: Rik van Riel <riel@redhat.com>
Looks good^Wbetter. I have nothing specific to say other than I've been staring at it for 10 minutes :)
Reviewed-by: Michel Lespinasse <walken@google.com>
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |