| From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() | Date | Thu, 28 Mar 2013 16:32:27 +0200 (EET) |
| |
Dave wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > > - BUG_ON(!PageAnon(page)); > > Did you really mean to kill these BUG_ON()s? They still look relevant > to me.
The zero page BUG_ON() is moved to new split_huge_page(). !PageAnon(page) we now can handle.
Note: nobody should call split_anon_huge_page() directly, only split_huge_page().
-- Kirill A. Shutemov
|