Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 27 Mar 2013 10:07:52 -0700 | Subject | Re: [PATCH v2] perf: add callgrind conversion tool | From | Roberto Vitillo <> |
| |
On Wed, Mar 27, 2013 at 12:23 AM, Namhyung Kim <namhyung@kernel.org> wrote: > Hi Roberto, > > On Tue, 26 Mar 2013 12:14:49 -0700, Roberto Vitillo wrote: >> The proposed patch adds the convert tool to perf which allows to convert a >> perf.data file to a set of callgrind data files which can subsequently be >> displayed with kcachegrind. >> >> Note that the code may trigger the following bug in libbfd: >> http://sourceware.org/bugzilla/show_bug.cgi?id=15106 > > Does it now support call graph too? Great if so!
Yes it does.
> Anyway, I suggest that splitting patch to two - one for addr2line and > another for actual 'convert' tool.
Ok
> I think we *can* use the tool > without libbfd (but with external addr2line binary or even with no line > number information).
Well, I could use the external addr2line binary but the tool will become terribly slow. A warning message could notify the user to recompile perf with libbfd to speed up the conversion.
| ![\](/images/icornerr.gif) |