lkml.org 
[lkml]   [2013]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] UAPI: Remove empty Kbuild files
On Tue, 26 Mar 2013 20:59:43 +0000 David Howells <dhowells@redhat.com> wrote:

> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > Remove empty Kbuild files as they cause problems with the patch program
> > > which removes files that become empty.
> > >
> > > Should I also remove include/Kbuild as that now does nothing? Or should
> > > it be left as an anchor just in case we want it in future?
> >
> > I think that if the build system created it, a `make clean' or `make
> > mproper' should rub it out again. Ideally a `make mrproper' will give
> > you a tree which is identical to a freshly-untarred kernel.org tarball
> > (yes?).
>
> Ummm... What's that got to do with it? include/Kbuild is part of the
> sources: make clean/mrproper/distclean should not be removing it.

Obviously, I thought you were referring to build-time operations.

> > Which reminds me of my email which you're still hiding from ;)
> > Shouldn't a `make mrproper' undo the effects of `make headers_install'
> > by wiping ./usr/include/?
>
> Ummm...
>
> warthog>cp .../.config .
> warthog>make -j12 >&/dev/null
> warthog>find usr/include/ | wc -l
> 873
> warthog>make distclean >&/dev/null
> warthog>find usr/include/ | wc -l
> find: `usr/include/': No such file or directory
> 0
>
> and:
>
> warthog>cp .../.config .
> warthog>make -j12 >&/dev/null
> warthog>find usr/include/ | wc -l
> 873
> warthog>make mrproper >&/dev/null
> warthog>find usr/include/ | wc -l
> find: `usr/include/': No such file or directory
> 0
>
> so I don't see the problem.

Well damn. I tested this a few days ago and a `make mrproper' didn't
remove usr/include. Did something change recently? If not, something
odd is going on. I definitely tested it.



\
 
 \ /
  Last update: 2013-03-29 00:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog