Messages in this thread | | | Date | Wed, 27 Mar 2013 00:03:59 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH] staging: zsmalloc: Fix link error on ARM |
| |
On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote: > On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote: > > Testing the arm chromebook config against the upstream > > kernel produces a linker error for the zsmalloc module from > > staging. The symbol flush_tlb_kernel_range is not available > > there. Fix this by removing the reimplementation of > > unmap_kernel_range in the zsmalloc module and using the > > function directly. > > > > Signed-off-by: Joerg Roedel <joro@8bytes.org> > > Why is this not an error for any other architecture? Why is arm > special?
The version of the function __zs_unmap_object() which uses flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in the same file only when CONFIG_ARM is defined. So this happens only on ARM.
Regards,
Joerg
| |