lkml.org 
[lkml]   [2013]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 4/7] KEYS: split call to call_usermodehelper_fns()
Date
Oleg Nesterov <oleg@redhat.com> wrote:

> Looks correct, but can't we simpluify it a bit?
>
> info = call_usermodehelper_setup(session_keyring);
> if (!info)
> return ENOMEM;

-ENOMEM;-)

> key_get(session_keyring));
> return call_usermodehelper_exec(info);

Looks reasonable. I like it better this way as it makes working out how to
deal with all the error cases so much simpler:-).

Acked-by: David Howells <dhowells@redhat.com>


\
 
 \ /
  Last update: 2013-03-25 14:41    [W:0.087 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site