Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v2 4/7] KEYS: split call to call_usermodehelper_fns() | Date | Mon, 25 Mar 2013 12:55:19 +0000 |
| |
Oleg Nesterov <oleg@redhat.com> wrote:
> Looks correct, but can't we simpluify it a bit? > > info = call_usermodehelper_setup(session_keyring); > if (!info) > return ENOMEM;
-ENOMEM;-)
> key_get(session_keyring)); > return call_usermodehelper_exec(info);
Looks reasonable. I like it better this way as it makes working out how to deal with all the error cases so much simpler:-).
Acked-by: David Howells <dhowells@redhat.com>
| |