Messages in this thread | | | Date | Fri, 22 Mar 2013 12:22:23 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH] memcg: fix memcg_cache_name() to use cgroup_name() |
| |
On 03/22/2013 12:17 PM, Li Zefan wrote: >> GFP_TEMPORARY groups short lived allocations but the mem cache is not >> > an ideal candidate of this type of allocations.. >> > > I'm not sure I'm following you... > > char *memcg_cache_name() > { > char *name = alloc(); > return name; > } > > kmem_cache_dup() > { > name = memcg_cache_name(); > kmem_cache_create_memcg(name); > free(name); > } > > Isn't this a short lived allocation? >
Hi,
Thanks for identifying and fixing this.
Li is right. The cache name will live long, but this is because the slab/slub caches will strdup it internally. So the actual memcg allocation is short lived.
| |