lkml.org 
[lkml]   [2013]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM
    On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote:
    > On 03/14/2013 07:13:46 PM, Kevin Hilman wrote:
    > >The new context tracking subsystem unconditionally includes kvm_host.h
    > >headers for the guest enter/exit macros. This causes a compile
    > >failure when KVM is not enabled.
    > >
    > >Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can
    > >be included/compiled even when KVM is not enabled.
    > >
    > >Cc: Frederic Weisbecker <fweisbec@gmail.com>
    > >Signed-off-by: Kevin Hilman <khilman@linaro.org>
    > >---
    > >Applies on v3.9-rc2
    > >
    > > include/linux/kvm_host.h | 7 ++++++-
    > > 1 file changed, 6 insertions(+), 1 deletion(-)
    >
    > This broke the PPC non-KVM build, which was relying on stub
    > functions in kvm_ppc.h, which relies on "struct vcpu" in kvm_host.h.
    >
    > Why can't the entirety kvm_host.h be included regardless of
    > CONFIG_KVM, just like most other feature-specific headers? Why
    > can't the if/else just go around the functions that you want to stub
    > out for non-KVM builds?
    >
    Kevin,

    What compilation failure this patch fixes? I presume something ARM
    related.

    --
    Gleb.


    \
     
     \ /
      Last update: 2013-03-21 09:01    [W:4.113 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site