Messages in this thread | | | Date | Thu, 21 Mar 2013 11:35:13 -0700 | From | Tejun Heo <> | Subject | Re: [PATCHSET] idr: implement idr_alloc() and convert existing users |
| |
Hello,
On Thu, Mar 21, 2013 at 10:06:18AM -0400, J. Bruce Fields wrote: > > Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC > > after the first wraparound. There are several cyclic users in the > > kernel and I think it probably would be best to implement cyclic > > support in idr. > > Are you looking at this, by the way, or do you have any suggestions? > > Wondering if it's something I should try to fix or if I should look into > converting to some other data structure here.
I am not working on it at the moment but I think the logical thing to do would be implementing cyclic support in idr and enabling it with, say, a different initializer - IDR_CYCLIC_INIT() or something. If you wanna fix it, please go ahead. :)
Thanks.
-- tejun
| |