Messages in this thread | | | Date | Wed, 20 Mar 2013 08:48:14 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 01/10] workqueue: add wq_numa_tbl_len and wq_numa_possible_cpumask[] |
| |
On Wed, Mar 20, 2013 at 11:43:30PM +0800, Lai Jiangshan wrote: > > + for_each_node(node) > > + BUG_ON(!alloc_cpumask_var_node(&wq_numa_possible_cpumask[node], > > + GFP_KERNEL, node)); > > + for_each_possible_cpu(cpu) { > > + node = cpu_to_node(cpu); > > + if (WARN_ON(node == NUMA_NO_NODE)) { > > + pr_err("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu); > > since you used WARN_ON(), not BUG_ON(), I think you need to free > allocated memory here.
I don't know. Is it necessary? It shouldn't happen sans bugs in arch code and we're vomiting warning message with full stack trace. The system will function but something is seriously screwed. I don't think it matters whether we free the puny number of bytes there or not and I don't wanna nest deeper there. :P
-- tejun
| |