| Subject | Re: [PATCH v5 28/44] tty: Remove ldsem recursion support | From | Peter Hurley <> | Date | Mon, 18 Mar 2013 20:01:01 -0400 |
| |
On Mon, 2013-03-18 at 16:59 -0700, Greg Kroah-Hartman wrote: > On Mon, Mar 11, 2013 at 04:44:48PM -0400, Peter Hurley wrote: > > Read lock recursion is no longer required for ldisc references; > > remove mechanism. > > > > Signed-off-by: Peter Hurley <peter@hurleysoftware.com> > > --- > > drivers/tty/tty_ldsem.c | 83 +++++------------------------------------------ > > include/linux/tty_ldisc.h | 2 -- > > 2 files changed, 8 insertions(+), 77 deletions(-) > > Wait, why did you add something 3 patches ago, only to remove it here? > Why not just smush these patches together in the first place?
From [PATCH v5 00/44] ldisc patchset...
On Mon, 2013-03-11 at 16:44 -0400, Peter Hurley wrote: > v5 changes: > > After completing an audit of the recursive use of ldisc > references, I discovered the _blocking_ recursive acquisition > of ldisc references was limited to line disciplines misusing > the tty_perform_flush() function. > With that now resolved in, > 'tty: Fix recursive deadlock in tty_perform_flush()' > the recursion design in ldsem has been removed. > > The recursion removal is in its own patch, > 'tty: Remove ldsem recursion support' > to ease review for those that have already reviewed the > ldsem implementation.
|